[camera] Fix disposed exceptions for the camera example on iOS #4692
Conversation
This comment has been minimized.
This comment has been minimized.
|
Test result without the fix: |
AlexV525
force-pushed
the
fix-camera-example-exceptions
branch
2 times, most recently
from
5897588 to
6594de8
Compare
|
Hi, can you add more details in the description? is it to hide the permission bug from the example project? (if that's the case it is probably better not to hide it so we know there's a bug there) |
@hellohuanlin Updated. It's more like a race conditions issue, and it could happen other than the permission issue. |
AlexV525
force-pushed
the
fix-camera-example-exceptions
branch
from
6594de8 to
5b3d3ff
Compare
Will this PR hide the permission issue mentioned in flutter/flutter#97199? |
Indeed, we can hold this though. |
We generally changelog for example-only changes; see the discussion in the link for that PR item. (Otherwise the bot would be configured not to require the override for that case.) |
|
What's the status of this PR? |
I'm holding this and see if it's still necessary after @hellohuanlin apply fixes to flutter/flutter#97199. |
|
since this PR hides the bug in the example code, it may not be a good idea to land it |
No CHANGELOG change: only affects the example.
No version change: only affects the example.
Related to flutter/flutter#97199.
Controllers were given to the field aggressively, which cause race conditions when initializing controllers. Now the code will remove the references ASAP when a controller has been disposed.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.